[dpdk-dev] [PATCH 21.05] app/testpmd: count outer IP checksum errors

Ferruh Yigit ferruh.yigit at intel.com
Tue Feb 23 19:35:50 CET 2021


On 1/31/2021 11:53 AM, Wisam Monther wrote:
> Hi,
> 
>> -----Original Message-----
>> From: dev <dev-bounces at dpdk.org> On Behalf Of Lance Richardson
>> Sent: Saturday, January 30, 2021 12:36 AM
>> To: Wenzhuo Lu <wenzhuo.lu at intel.com>; Xiaoyun Li
>> <xiaoyun.li at intel.com>; Bernard Iremonger
>> <bernard.iremonger at intel.com>
>> Cc: dev at dpdk.org; Ajit Kumar Khaparde <ajit.khaparde at broadcom.com>;
>> Kalesh Anakkur Purayil <kalesh-anakkur.purayil at broadcom.com>
>> Subject: [dpdk-dev] [PATCH 21.05] app/testpmd: count outer IP checksum
>> errors
>>
>> Count and display outer IP checksum errors in the checksum forwarder.
>>
>> Example forwarder stats output:
>>    RX-packets: 158            RX-dropped: 0             RX-total: 158
>>    Bad-ipcsum: 48             Bad-l4csum: 48            Bad-outer-l4csum: 6
>>    Bad-outer-ipcsum: 40
>>    TX-packets: 0              TX-dropped: 0             TX-total: 0
>>
>> Signed-off-by: Lance Richardson <lance.richardson at broadcom.com>
>> Reviewed-by: Ajit Kumar Khaparde <ajit.khaparde at broadcom.com>
>> Reviewed-by: Kalesh Anakkur Purayil <kalesh-
>> anakkur.purayil at broadcom.com>
> 
> Acked-by: Wisam Jaddo <wisamm at nvidia.com>
> 

Reviewed-by: Ferruh Yigit <ferruh.yigit at intel.com>
Applied to dpdk-next-net/main, thanks.



'PKT_RX_EIP_CKSUM_BAD' is documented in mbuf header as:
"/** External IP header checksum error. */"

I think	'External' wording is confusing, as well as 'EIP' abbreviation, what do 
you think to create another macro alias to existing one, and mark the old one as 
deprecated?



More information about the dev mailing list