[dpdk-dev] [EXT] Re: [PATCH v3] meson: update meson build for armada drivers

[Luca Boccassi]

On Mon, 2021-01-11 at 17:07 +0000, Bruce Richardson wrote:
> On Mon, Jan 11, 2021 at 05:17:01PM +0100, Thomas Monjalon wrote:
> > 11/01/2021 17:08, Liron Himi:
> > > From: Thomas Monjalon <thomas at monjalon.net> 
> > > Sent: Monday, 11 January 2021 18:05
> > > To: Liron Himi <lironh at marvell.com>
> > > Cc: ferruh.yigit at intel.com; dev at dpdk.org; Jerin Jacob Kollanukkaran <jerinj at marvell.com>; Liron Himi <lironh at marvell.com>
> > > Subject: Re: [EXT] Re: [dpdk-dev] [PATCH v3] meson: update meson build for armada drivers
> > > 
> > > 11/01/2021 16:29, Liron Himi:
> > > > Hi Thomas,
> > > > 
> > > > When did you take this MUSDK version?
> > > > Is this your head "pkg-config: expose dma-add-size"?
> > > 
> > > I'm using musdk-SDK-10.3.5.0-PR2 as recommended in the doc.
> > > 
> > > > If not, this explain the mvneta issue.
> > > > I already noticed that and pushed a fixed to the github.
> > > 
> > > I see. So it may need a doc update.
> > > [L.H.] why need to update the doc? It is still the same release branch, I just added a fix patch to it.
> > 
> > Yes, my bad: I used the tag musdk-SDK-10.3.5.0-PR2
> > instead of the branch musdk-release-SDK-10.3.5.0-PR2.
> > 
> > > > As for the prefix issue,
> > > > The prefix is being set in the 'configure' phase by using the '--prefix' variable. Have you tried that?
> > > 
> > > No I didn't try that, and I'm using DESTDIR variable when installing.
> > > Whould it be possible to update the prefix with DESTDIR when installing?
> > > [L.H.] need to explore this option. But for now use 'prefix', as this is what supported by MUSDK
> > 
> > OK
> > 
> [+Luca]
> 
> I think it would be wrong to update the .pc file based on DESTDIR, as I
> believe DESTDIR is used by packaging to produce the actual package layout
> in a non-root path. To change the default installation path for a package
> on the current system, "--prefix" is the correct parameter to use.
> 
> /Bruce

+1

-- 
Kind regards,
Luca Boccassi