[dpdk-dev] [PATCH v2 5/6] app/regex: support performance measurements per QP

[David Christensen]

>>> -----Original Message-----
>>> From: Thomas Monjalon <thomas at monjalon.net>
>>> Sent: Friday, January 8, 2021 11:09 AM
>>> To: Ophir Munk <ophirmu at nvidia.com>
>>> Cc: dev at dpdk.org; Ori Kam <orika at nvidia.com>
>>> Subject: Re: [dpdk-dev] [PATCH v2 5/6] app/regex: support performance
>>> measurements per QP
>>>
>>> 20/12/2020 11:41, Ophir Munk:
>>>> Up to this commit measuring the parsing elapsed time and Giga bits per
>>>> second performance was done on the aggregation of all QPs (per core).
>>>> This commit separates the time measurements per individual QP.
>>>>
>>>> Signed-off-by: Ophir Munk <ophirmu at nvidia.com>
>>>> ---
>>>> --- a/app/test-regex/main.c
>>>> +++ b/app/test-regex/main.c
>>>> +	for (qp_id = 0; qp_id < nb_qps; qp_id++) {
>>>> +		time = ((double)qp->end - qp->start) / CLOCKS_PER_SEC;
>>>
>>> This line triggers an error with PPC compiler:
>>> error: ‘qp’ may be used uninitialized in this function [-Werror=maybe-
>>> uninitialized]
>>>     time = ((double)qp->end - qp->start) / CLOCKS_PER_SEC;
>>>
>> Thanks for reporting.
>> I sent v3 with a fix.
>> Could I have known this error in advance? Is there a CI report?
> 
> No I think there is no CI report for PPC.
> Actually the PPC support in DPDK is not clear.

IBM is still supporting DPDK on PPC, though we don't have a proper CI 
infrastructure in place.  PPC support is available from Travis but was 
unreliable when we last attempted to enable it.  I'll take Thomas' hint 
the hint and revisit the issue in 2021.

Dave

FYI, v2 of the patch built successfully on my PPC test system with gcc 
8.3.1.  There's a compiler difference between my RH8 environment and the 
cross-build environment Thomas references.