[dpdk-dev] [PATCH] net/mvneta: check allocation in rx queue flush
Jerin Jacob
jerinjacobk at gmail.com
Tue Jan 12 15:21:06 CET 2021
On Mon, Dec 7, 2020 at 5:07 PM wangyunjian <wangyunjian at huawei.com> wrote:
>
> From: Yunjian Wang <wangyunjian at huawei.com>
>
> The function rte_malloc() could return NULL, the return value
> need to be checked.
>
> Fixes: ce7ea764597e ("net/mvneta: support Rx/Tx")
> Cc: stable at dpdk.org
>
> Signed-off-by: Yunjian Wang <wangyunjian at huawei.com>
Acked-by: Liron Himi <lironh at marvell.com>
Applied to dpdk-next-net-mrvl/for-main. Thanks
> ---
> drivers/net/mvneta/mvneta_rxtx.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/net/mvneta/mvneta_rxtx.c b/drivers/net/mvneta/mvneta_rxtx.c
> index 10b6f57584..dfa7ecc090 100644
> --- a/drivers/net/mvneta/mvneta_rxtx.c
> +++ b/drivers/net/mvneta/mvneta_rxtx.c
> @@ -872,7 +872,17 @@ mvneta_rx_queue_flush(struct mvneta_rxq *rxq)
> int ret, i;
>
> descs = rte_malloc("rxdesc", MRVL_NETA_RXD_MAX * sizeof(*descs), 0);
> + if (descs == NULL) {
> + MVNETA_LOG(ERR, "Failed to allocate descs.");
> + return;
> + }
> +
> bufs = rte_malloc("buffs", MRVL_NETA_RXD_MAX * sizeof(*bufs), 0);
> + if (bufs == NULL) {
> + MVNETA_LOG(ERR, "Failed to allocate bufs.");
> + rte_free(descs);
> + return;
> + }
>
> do {
> num = MRVL_NETA_RXD_MAX;
> --
> 2.23.0
>
More information about the dev
mailing list