[dpdk-dev] [PATCH 04/40] net/virtio: introduce PCI device metadata

Maxime Coquelin maxime.coquelin at redhat.com
Thu Jan 14 12:05:27 CET 2021



On 1/5/21 10:16 PM, David Marchand wrote:
> On Sun, Dec 20, 2020 at 10:14 PM Maxime Coquelin
> <maxime.coquelin at redhat.com> wrote:
>>
>> This patch initiate refactoring of Virtio PCI, by introducing
>> a new device structure for PCI-specific metadata.
> 
> This works, but this patch seems artificial.
> 
> The eth_virtio_dev_init expects dev->data->dev_private to be a virtio_hw object.
> You can introduce this later in the series when really needed.
> 
> 
I propose to squash it into patch 5, which moves PCI specific init to a
dedicated file.

Is that OK for you?

Thanks,
Maxime



More information about the dev mailing list