[dpdk-dev] [EXT] Re: [PATCH v2] net/qede: fix regression introduced by b10231aed1ed

[Jerin Jacob]

On Tue, Jan 12, 2021 at 11:25 AM Rasesh Mody <rmody at marvell.com> wrote:
>
> > From: Jerin Jacob <jerinjacobk at gmail.com>
> > Sent: Tuesday, January 12, 2021 10:21 AM
> >
> > On Mon, Jan 4, 2021 at 7:47 PM Rasesh Mody <rmody at marvell.com> wrote:
> > >
> > > > From: dev <dev-bounces at dpdk.org> On Behalf Of Igor Russkikh
> > > > Sent: Monday, January 4, 2021 6:15 PM
> > > >
> > > > > When calling rte_eth_promiscuous_enable(port_id) followed by
> > > > > rte_eth_allmulticast_enable(port_id), the port is not in promisc
> > > > > mode anymore. This patch ensures that promisc mode takes
> > > > > precedence over allmulticast mode fixing the regression introduced by
> > b10231aed1ed.
> >
> > Please add Fixes:
> >
> > > > >
> > > > > Signed-off-by: Balazs Nemeth <bnemeth at redhat.com>
> >

>
> Even if promiscuous mode is disabled after the change, allmulti mode setting will persist.
> Fix looks good to me.
>
> Acked-by: Rasesh Mody <rmody at marvell.com>


Fixed check-git-log.sh issues and applied to dpdk-next-net-mrvl/for-main. Thanks


>
> Thanks,
> Rasesh
>
> > > > Igor
>