[dpdk-dev] [PATCH v2 16/19] app/chkincs: add chkincs app to verify headers

[Thomas Monjalon]

15/01/2021 12:59, Bruce Richardson:
> On Fri, Jan 15, 2021 at 11:51:49AM +0000, Ferruh Yigit wrote:
> > On 1/15/2021 11:10 AM, Bruce Richardson wrote:
> > > To verify that all DPDK headers are ok for inclusion directly in a C
> > > file, and are not missing any other pre-requisite headers, we can
> > > auto-generate for each header an empty C file that includes that header.
> > > Compiling these files will throw errors if any header has unmet
> > > dependencies.
> > > 
> > > The list of headers to check is based of the "headers" value returned from
> > > each library's meson.build file. However, since not all headers are for
> > > direct inclusion, add a build variable "headers_no_chkincs" to list those
> > > headers and skip checking them.
> > > 
> > > Signed-off-by: Bruce Richardson <bruce.richardson at intel.com>
> > > ---
> > > 
> > > v2:
> > > * add maintainers entry
> > > * distribute exception list among meson.build files.
> > > 
> > >   MAINTAINERS                              |  4 ++++
> > >   app/chkincs/gen_c_file_for_header.py     | 12 ++++++++++
> > >   app/chkincs/main.c                       |  4 ++++
> > >   app/chkincs/meson.build                  | 28 ++++++++++++++++++++++++
> > 
> > +1 to have this kind of tool to check, but it is not an application like
> > others in the 'app' folder, what do you think placing it under 'devtools' or
> > 'buildtools'?
> 
> Couple of reasons why it's placed in app.
> 
> 1. We previously had a "chkincs" app in DPDK which was kept in the app
> folder
> 2. It allows us to reuse the build infrastructure for building apps, rather
> than reduplicating it.
> 3. We don't have any compilable code currently in the devtools folder, and
> even in buildtools the pmdinfogen app is going to go away.
> 
> That being said, none of those reasons are major issues that can't be
> worked around if the consensus is to move it.

It could be easily in devtools if it was a script.
By the way, we already have devtools/check-includes.sh
If your solution is better, please remove this script.