[dpdk-dev] [PATCH] test: don't break terminal settings when running tests
Thomas Monjalon
thomas at monjalon.net
Sun Jan 17 18:45:51 CET 2021
14/01/2021 18:01, Van Haaren, Harry:
> > From: Stephen Hemminger <stephen at networkplumber.org>
> > Sent: Thursday, January 14, 2021 4:46 PM
> > To: Richardson, Bruce <bruce.richardson at intel.com>; Van Haaren, Harry
> > <harry.van.haaren at intel.com>; De Lara Guarch, Pablo
> > <pablo.de.lara.guarch at intel.com>
> > Cc: stable at dpdk.org; dev at dpdk.org; Stephen Hemminger
> > <stephen at networkplumber.org>
> > Subject: [PATCH] test: don't break terminal settings when running tests
> >
> > When running one test (via DPDK_TEST) the test program
> > would leave the terminal in raw mode. This was because
> > it was setting up cmdline to do interactive input.
> >
> > The fix is to use cmdline_new() for the interactive
> > case.
> >
> > This also fixes a memory leak because the test
> > runner was never calling cmdline_free().
> >
> > Fixes: 9b848774a5dc ("test: use env variable to run tests")
> > Cc: harry.van.haaren at intel.com
> > Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
>
> Tested-by: Harry van Haaren <harry.van.haaren at intel.com>
Applied, thanks
More information about the dev
mailing list