[dpdk-dev] [PATCH v4 1/9] ethdev: introduce representor type

Xueming(Steven) Li xuemingl at nvidia.com
Tue Jan 19 00:41:14 CET 2021


>-----Original Message-----
>From: Ajit Khaparde <ajit.khaparde at broadcom.com>
>Sent: Tuesday, January 19, 2021 2:18 AM
>To: NBU-Contact-Thomas Monjalon <thomas at monjalon.net>
>Cc: Xueming(Steven) Li <xuemingl at nvidia.com>; Ferruh Yigit
><ferruh.yigit at intel.com>; Andrew Rybchenko
><andrew.rybchenko at oktetlabs.ru>; Olivier Matz <olivier.matz at 6wind.com>;
>dpdk-dev <dev at dpdk.org>; Slava Ovsiienko <viacheslavo at nvidia.com>; Asaf
>Penso <asafp at nvidia.com>
>Subject: Re: [dpdk-dev] [PATCH v4 1/9] ethdev: introduce representor type
>
>On Mon, Jan 18, 2021 at 10:15 AM Thomas Monjalon <thomas at monjalon.net>
>wrote:
>>
>> 18/01/2021 19:00, Ajit Khaparde:
>> > On Mon, Jan 18, 2021 at 9:57 AM Thomas Monjalon
><thomas at monjalon.net> wrote:
>> > > 18/01/2021 18:42, Ajit Khaparde:
>> > > > On Mon, Jan 18, 2021 at 3:17 AM Xueming Li <xuemingl at nvidia.com>
>wrote:
>> > > > > +enum rte_eth_representor_type {
>> > > > > +       RTE_ETH_REPRESENTOR_NONE, /**< not a representor. */
>> > > > > +       RTE_ETH_REPRESENTOR_VF,   /**< representor of VF. */
>> > > > > +       RTE_ETH_REPRESENTOR_SF,   /**< representor of SF. */
>> > > > Till we get used to the terminology...
>> > > > Can we also have SF = "Sub Function" mentioned in the docs or
>comments?
>> > >
>> > > Are we sure about the definition?
>> > > I remember seeing SF = Scalable Function somewhere else (maybe from
>Intel)
>> > That complicates it. But if they mean the same thing, let's pick one.
>>
>> I think "Sub Function" and "Virtual Function" are easy to understand
>> for everybody.
>> I suggest picking these two for comments above.
>+1

There was an internal discussion and the conclusion is to align with kernel driver name.
Will update comment in next version, thanks!

>
>>


More information about the dev mailing list