[dpdk-dev] [PATCH v2] net/iavf: fix VIRTHCNL_OP_SET_RSS_HENA handling

Zhang, Qi Z qi.z.zhang at intel.com
Tue Jan 19 04:45:20 CET 2021



> -----Original Message-----
> From: Ding, Xuan <xuan.ding at intel.com>
> Sent: Monday, January 18, 2021 4:28 PM
> To: Zhang, Qi Z <qi.z.zhang at intel.com>; Wu, Jingjing <jingjing.wu at intel.com>;
> Xing, Beilei <beilei.xing at intel.com>
> Cc: dev at dpdk.org; Ding, Xuan <xuan.ding at intel.com>; stable at dpdk.org
> Subject: [PATCH v2] net/iavf: fix VIRTHCNL_OP_SET_RSS_HENA handling
> 
> Allow error to be returned for VIRTCHNL_OP_SET_RSS_HENA when set hena = 0.
> Add warning that PF does not support hena = 0 now.

Actually this is not a fix, it's a workaround to handle some defect in legacy kernel driver.
So changed title and commit log as below:

	Title: workaround RSS cleanup failure handling

	Allow to ignore error returned from virtual channel command
    VIRTCHNL_OP_SET_RSS_HENA with hena = 0 due to some legacy
    kernel driver does not support this. Add warning message when
    this happen.

> 
> Fixes: 95f2f0e9fc2a6("net/iavf: improve default RSS")	

The fix line should be removed.

> Cc: stable at dpdk.org
> 
> Signed-off-by: Xuan Ding <xuan.ding at intel.com>

Acked by: Qi Zhang <qi.z.zhang at intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi


More information about the dev mailing list