[dpdk-dev] [PATCH v17 07/11] power: add PMD power management API and callback

[Burakov, Anatoly]

On 18-Jan-21 10:48 PM, Thomas Monjalon wrote:
> 14/01/2021 15:46, Anatoly Burakov:
>> From: Liang Ma <liang.j.ma at intel.com>
>>
>> +   Currently, this power management API is limited to mandatory mapping of 1
>> +   queue to 1 core (multiple queues are supported, but they must be polled from
>> +   different cores).
> 
> This is quite limited.
> Not sure librte_power is the right place for a flexible ethdev management.
> 

It's not really "managing" ethdev as such, it just installs a callback. 
You could say it's building on what's available in ethdev, but aside 
from installing a callback it doesn't do anything else.

<snip>

>> +static struct pmd_conf_data {
>> +	struct rte_cpu_intrinsics intrinsics_support;
>> +	/**< what do we support? */
>> +	uint64_t tsc_per_us;
>> +	/**< pre-calculated tsc diff for 1us */
>> +	uint64_t pause_per_us;
>> +	/**< how many rte_pause can we fit in a microisecond? */
> 
> Vim typo spotted: microisecond
> 
>> +} global_data;
> 
> Not sure about the need for a struct.
> Please insert comment before the field if not on the same line.
> BTW, why doxygen syntax in a .c file?
> 

The struct was really there to make autocomplete easier. I can make all 
of the variables static and pull them out if that's necessary, but i 
don't think it makes much difference.

(the rest of the comments will be implemented)

-- 
Thanks,
Anatoly