[dpdk-dev] [PATCH] net/ice: fix symmetric rule creating

Xuan Ding xuan.ding at intel.com
Thu Jan 21 08:26:57 CET 2021


Only allow to create symmetric rule for L3/L4.

Fixes: 38d632cbdc88("net/ice: refactor PF RSS")
Cc: stable at dpdk.org

Signed-off-by: Xuan Ding <xuan.ding at intel.com>
---
 drivers/net/ice/ice_hash.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c
index 2d23c8dd50..aee4761625 100644
--- a/drivers/net/ice/ice_hash.c
+++ b/drivers/net/ice/ice_hash.c
@@ -868,6 +868,13 @@ ice_any_invalid_rss_type(enum rte_eth_hash_function rss_func,
 		if (rss_type & (ETH_RSS_L3_SRC_ONLY | ETH_RSS_L3_DST_ONLY |
 		    ETH_RSS_L4_SRC_ONLY | ETH_RSS_L4_DST_ONLY))
 			return true;
+
+		if (!(rss_type &
+		   (ETH_RSS_IPV4 | ETH_RSS_IPV6 |
+		    ETH_RSS_NONFRAG_IPV4_UDP | ETH_RSS_NONFRAG_IPV6_UDP |
+		    ETH_RSS_NONFRAG_IPV4_TCP | ETH_RSS_NONFRAG_IPV6_TCP |
+		    ETH_RSS_NONFRAG_IPV4_SCTP | ETH_RSS_NONFRAG_IPV6_SCTP)))
+			return true;
 	}
 
 	/* check invalid combination */
-- 
2.17.1



More information about the dev mailing list