[dpdk-dev] [PATCH v2] mem: improve parameter checking on memory hotplug

Burakov, Anatoly anatoly.burakov at intel.com
Thu Jan 21 11:52:16 CET 2021


On 19-Jan-21 11:39 PM, Thomas Monjalon wrote:
> 18/01/2021 16:41, Anatoly Burakov:
>> +	/* now that we've validated the request, time for a PSA */
> 
> What is PSA?

Public Service Announcement :)

> 
>> +	eal_memalloc_mem_event_notify(RTE_MEM_EVENT_FREE,
>> +			m->free_req.addr, m->free_req.len);
> [...]
> 
>> +	/* this is checked by the API, but we need to prevent divide by zero */
>> +	if (ar->page_sz == 0 || !rte_is_power_of_2(ar->page_sz)) {
>> +		RTE_LOG(ERR, EAL, "Attempting to allocate with page size\n");
> 
> Is there a missing part in the log message?
> 

Seems like it. I'll resubmit.

-- 
Thanks,
Anatoly


More information about the dev mailing list