[dpdk-dev] [PATCH v2] app/testpmd: fix RSS key

Ferruh Yigit ferruh.yigit at intel.com
Fri Jan 22 15:58:47 CET 2021


On 1/22/2021 5:43 AM, Zhou, JunX W wrote:
<...>
> -----Original Message-----
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Zhang,Alvin
> Sent: Thursday, January 21, 2021 5:42 PM
> To: Yigit, Ferruh <ferruh.yigit at intel.com>
> Cc: dev at dpdk.org; Zhang, AlvinX <alvinx.zhang at intel.com>; stable at dpdk.org
> Subject: [dpdk-dev] [PATCH v2] app/testpmd: fix RSS key
> 
> From: Alvin Zhang <alvinx.zhang at intel.com>
> 
> Since the patch '1848b117' has initialized the variable 'key' in 'struct rte_flow_action_rss' with 'NULL', the PMD cannot get the RSS key now. Details as bellow:
> 
> testpmd> flow create 0 ingress pattern eth / ipv4 / end actions
>           rss types ipv4-other end key
>           1234567890123456789012345678901234567890FFFFFFFFFFFF123
>           4567890123456789012345678901234567890FFFFFFFFFFFF
>           queues end / end
> Flow rule #1 created
> testpmd> show port 0 rss-hash key
> RSS functions:
>           all ipv4-other ip
> RSS key:
>           4439796BB54C5023B675EA5B124F9F30B8A2C03DDFDC4D02A08C9B3
>           34AF64A4C05C6FA343958D8557D99583AE138C92E81150366
> 
> This patch sets offset and size of the 'key' variable as the first parameter of the token 'key'. Later, the address of the RSS key will be copied to 'key' variable.
> 
> Fixes: 1848b117cca1 ("app/testpmd: fix RSS key for flow API RSS rule")
> Cc: stable at dpdk.org
> 
> Signed-off-by: Alvin Zhang <alvinx.zhang at intel.com>
 >
> Tested-by: Zhou, Jun <junx.w.zhou at intel.com>
> 
Reviewed-by: Ferruh Yigit <ferruh.yigit at intel.com>

Applied to dpdk-next-net/main, thanks.


More information about the dev mailing list