[dpdk-dev] [PATCH v2 1/3] cryptodev: add feature flag for SSL/TLS order

[Akhil Goyal]

Hi Tejasree,

> Subject: [PATCH v2 1/3] cryptodev: add feature flag for SSL/TLS order
> 
> Added device feature flag for SSL/TLS way of cipher-auth
> operations support i.e. auth generation followed by encryption
> and decryption followed by auth verify so that SSL/TLS tests
> are skipped if the device doesn't support the feature.
> 
> Signed-off-by: Tejasree Kondoj <ktejasree at marvell.com>
> ---

Is it something different than 
#define RTE_CRYPTODEV_FF_DIGEST_ENCRYPTED               (1ULL << 19)
/**< Support encrypted-digest operations where digest is appended to data */

@Fan: could you review this patchset.

>  doc/guides/cryptodevs/features/default.ini | 1 +
>  doc/guides/rel_notes/release_21_02.rst     | 7 +++++++
>  lib/librte_cryptodev/rte_cryptodev.h       | 2 ++
>  3 files changed, 10 insertions(+)
> 
> diff --git a/doc/guides/cryptodevs/features/default.ini
> b/doc/guides/cryptodevs/features/default.ini
> index 17b177fc45..cd5f75d8f6 100644
> --- a/doc/guides/cryptodevs/features/default.ini
> +++ b/doc/guides/cryptodevs/features/default.ini
> @@ -31,6 +31,7 @@ CPU crypto             =
>  Symmetric sessionless  =
>  Non-Byte aligned data  =
>  Sym raw data path API  =
> +SSL way of chaining    =
> 
>  ;
>  ; Supported crypto algorithms of a default crypto driver.
> diff --git a/doc/guides/rel_notes/release_21_02.rst
> b/doc/guides/rel_notes/release_21_02.rst
> index e72a582b1b..45854d5d33 100644
> --- a/doc/guides/rel_notes/release_21_02.rst
> +++ b/doc/guides/rel_notes/release_21_02.rst
> @@ -82,6 +82,13 @@ New Features
>    enable applications to add/remove user callbacks which gets called
>    for every enqueue/dequeue operation.
> 
> +* **Added feature flag in cryptodev library.**
> +
> +  Added device feature flag for SSL/TLS way of cipher-auth operations support
> +  i.e. auth generation followed by encryption and decryption followed by
> +  auth verify in cryptodev library so that SSL/TLS tests are skipped if the
> +  device doesn't support the feature.
> +
>  * **Updated the OCTEON TX2 crypto PMD.**
> 
>    * Updated the OCTEON TX2 crypto PMD lookaside protocol offload for IPsec
> with
> diff --git a/lib/librte_cryptodev/rte_cryptodev.h
> b/lib/librte_cryptodev/rte_cryptodev.h
> index ae34f33f69..6ee3f33c06 100644
> --- a/lib/librte_cryptodev/rte_cryptodev.h
> +++ b/lib/librte_cryptodev/rte_cryptodev.h
> @@ -461,6 +461,8 @@ rte_cryptodev_asym_get_xform_enum(enum
> rte_crypto_asym_xform_type *xform_enum,
>  /**< Support operations on data which is not byte aligned */
>  #define RTE_CRYPTODEV_FF_SYM_RAW_DP			(1ULL << 24)
>  /**< Support accelerator specific symmetric raw data-path APIs */
> +#define RTE_CRYPTODEV_FF_SSL_ORDER			(1ULL << 25)
> +/**< Support SSL order of cipher-auth xforms chaining */
> 
>  /**
>   * Get the name of a crypto device feature flag
> --
> 2.27.0