[dpdk-dev] [PATCH] net/i40e: fix mingw build error

[Rong, Leyi]

> -----Original Message-----
> From: Tal Shnaiderman <talshn at nvidia.com>
> Sent: Wednesday, January 27, 2021 1:04 AM
> To: Rong, Leyi <leyi.rong at intel.com>; Zhang, Qi Z <qi.z.zhang at intel.com>;
> Kadam, Pallavi <pallavi.kadam at intel.com>; Yigit, Ferruh
> <ferruh.yigit at intel.com>; Menon, Ranjit <ranjit.menon at intel.com>; Xing, Beilei
> <beilei.xing at intel.com>
> Cc: dev at dpdk.org
> Subject: RE: [dpdk-dev] [PATCH] net/i40e: fix mingw build error
> 
> > Subject: [dpdk-dev] [PATCH] net/i40e: fix mingw build error
> >
> > External email: Use caution opening links or attachments
> >
> >
> > Disable i40e avx512 code path for windows build to avoid the mingw
> > build error.
> >
> > Fixes: e6a6a138919f ("net/i40e: add AVX512 vector path")
> >
> > Signed-off-by: Leyi Rong <leyi.rong at intel.com>
> > ---
> >  config/x86/cross-mingw       | 3 +++
> >  drivers/net/i40e/meson.build | 2 +-
> >  2 files changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/config/x86/cross-mingw b/config/x86/cross-mingw index
> > 4c15a7fa2e..48a82b457e 100644
> > --- a/config/x86/cross-mingw
> > +++ b/config/x86/cross-mingw
> > @@ -11,3 +11,6 @@ system = 'windows'
> >  cpu_family = 'x86_64'
> >  cpu = 'native'
> >  endian = 'little'
> > +
> > +[properties]
> > +c_args = '-mno-avx512f'
> 
> Should be in a different patch since it effects the whole project.
> 

Sure, will be split in v2.

> > diff --git a/drivers/net/i40e/meson.build
> > b/drivers/net/i40e/meson.build index c0acdf4fd4..c9a1a50407 100644
> > --- a/drivers/net/i40e/meson.build
> > +++ b/drivers/net/i40e/meson.build
> > @@ -54,7 +54,7 @@ if arch_subdir == 'x86'
> >                 cc.has_argument('-mavx512f') and
> >                 cc.has_argument('-mavx512bw'))
> >
> > -       if i40e_avx512_cpu_support == true or i40e_avx512_cc_support == true
> > +       if not is_windows and (i40e_avx512_cpu_support == true or
> > + i40e_avx512_cc_support == true)
> 
> DmitryK already mentioned it previously; you only need to disabled MinGW64
> since clang isn't seeing those errors.
> 

Yes, will support the case when clang is enable.