[dpdk-dev] [dpdk-stable] [PATCH 2/2] net/mlx5: use global default miss for E-Switch sampling
Jiawei(Jonny) Wang
jiaweiw at nvidia.com
Wed Jan 27 16:25:11 CET 2021
Hi Ferruh,
> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit at intel.com>
> Sent: Wednesday, January 27, 2021 8:50 PM
> To: Jiawei(Jonny) Wang <jiaweiw at nvidia.com>; Slava Ovsiienko
> <viacheslavo at nvidia.com>; Matan Azrad <matan at nvidia.com>; Ori Kam
> <orika at nvidia.com>; NBU-Contact-Thomas Monjalon
> <thomas at monjalon.net>
> Cc: dev at dpdk.org; Raslan Darawsheh <rasland at nvidia.com>;
> stable at dpdk.org; Kevin Traynor <ktraynor at redhat.com>; Luca Boccassi
> <bluca at debian.org>
> Subject: Re: [dpdk-stable] [PATCH 2/2] net/mlx5: use global default miss for
> E-Switch sampling
>
> On 1/26/2021 12:53 PM, Jiawei Wang wrote:
> > In E-Switch steering domain there was dedicated default miss action
> > created for every sampling flow.
> > The patch replaces this one with the global default miss action.
> >
>
> Hi Jiawei,
>
> The impact of the patch is not clear, what was the problem using action per
> flow? What will change when global action is used? Is this fixing some
> problem or is it optimization by preventing per flow action?
>
The patch is optimization not fix, MLX5 PMD can reuses the global action don’t need allocate new one each time.
> > Cc: stable at dpdk.org
> >
>
> Since this looks like optimization, I am removing the stable tag for now.
Yes, please remove this tag.
Thanks.
>
> If it is a fix, please reply with a fixes line, I can update it in next-net.
>
> > Signed-off-by: Jiawei Wang <jiaweiw at nvidia.com>
> > Acked-by: Viacheslav Ovsiienko <viacheslavo at nvidia.com>
More information about the dev
mailing list