[dpdk-dev] [PATCH v5 05/11] net/octeontx_ep: add dev info get and configure

Ferruh Yigit ferruh.yigit at intel.com
Thu Jan 28 17:56:15 CET 2021


On 1/28/2021 3:22 PM, Nalla Pradeep wrote:
> Add device information get and device configure operations.
> 
> Signed-off-by: Nalla Pradeep <pnalla at marvell.com>

<...>

> +static int
> +otx_ep_dev_configure(struct rte_eth_dev *eth_dev)
> +{
> +	struct otx_ep_device *otx_epvf = OTX_EP_DEV(eth_dev);
> +	struct rte_eth_dev_data *data = eth_dev->data;
> +	struct rte_eth_rxmode *rxmode;
> +	struct rte_eth_txmode *txmode;
> +	struct rte_eth_conf *conf;
> +
> +	conf = &data->dev_conf;
> +	rxmode = &conf->rxmode;
> +	txmode = &conf->txmode;
> +	if (eth_dev->data->nb_rx_queues > otx_epvf->max_rx_queues ||
> +	    eth_dev->data->nb_tx_queues > otx_epvf->max_tx_queues) {
> +		otx_ep_err("invalid num queues\n");
> +		return -ENOMEM;

I can see there are a few more 'ENOMEM' return are remaining, can you please 
scan all code for improper return value usage?




More information about the dev mailing list