[dpdk-dev] [PATCH v6 04/12] net/octeontx_ep: add device init and uninit

Ferruh Yigit ferruh.yigit at intel.com
Fri Jan 29 10:19:32 CET 2021


On 1/29/2021 12:16 AM, Nalla Pradeep wrote:
> Add basic init and uninit function which includes
> initializing fields of ethdev private structure.
> 
> Signed-off-by: Nalla Pradeep <pnalla at marvell.com>

<...>

> @@ -43,6 +104,7 @@ otx_ep_eth_dev_pci_remove(struct rte_pci_device *pci_dev)
>   /* Set of PCI devices this driver supports */
>   static const struct rte_pci_id pci_id_otx_ep_map[] = {
>   	{ RTE_PCI_DEVICE(PCI_VENDOR_ID_CAVIUM, PCI_DEVID_OCTEONTX_EP_VF) },
> +	{ RTE_PCI_DEVICE(PCI_VENDOR_ID_CAVIUM, PCI_DEVID_OCTEONTX2_EP_NET_VF) },

Can you please move this to 3/12 where 'pci_id_otx_ep_map' is introduced?

>   	{ RTE_PCI_DEVICE(PCI_VENDOR_ID_CAVIUM, PCI_DEVID_CN98XX_EP_NET_VF) },
>   	{ .vendor_id = 0, /* sentinel */ }
>   };
> @@ -57,3 +119,6 @@ static struct rte_pci_driver rte_otx_ep_pmd = {
>   RTE_PMD_REGISTER_PCI(net_otx_ep, rte_otx_ep_pmd);
>   RTE_PMD_REGISTER_PCI_TABLE(net_otx_ep, pci_id_otx_ep_map);
>   RTE_PMD_REGISTER_KMOD_DEP(net_otx_ep, "* igb_uio | vfio-pci");
> +RTE_LOG_REGISTER(otx_net_ep_logdbg, pmd.net.octeontx_ep, DEBUG);
> +RTE_LOG_REGISTER(otx_net_ep_logerr, pmd.net.octeontx_ep, ERR);
> +RTE_LOG_REGISTER(otx_net_ep_loginfo, pmd.net.octeontx_ep, INFO);
> 

This is wrong. You should register single logtype, as done in v5, and use for 
various log levels.

Please make the default log level for registered logtype 'NOTICE' (again as done 
in v5)

The macros 'otx_ep_info', 'otx_ep_err' & 'otx_ep_dbg' should share same logtype.


More information about the dev mailing list