[dpdk-dev] [PATCH] net/ice: fix memzone leak when firmware is missing

David Marchand david.marchand at redhat.com
Tue Jul 6 15:27:48 CEST 2021


On Tue, Jul 6, 2021 at 2:53 PM Wang, Haiyue <haiyue.wang at intel.com> wrote:
> > > The function 'ice_deinit_hw' should be used. ;-)
> > >
> > >
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/net/ethernet/intel/ice
> > /ice_main.c#n4508
> >
> > Well I was inspired by ice_dev_close(), so I guess this code too could
> > use some cleanup but I don't have the hw anymore to test this change.
> > I'll trust you and simply update ice_dev_init.

Adding to this, there are other potential leaks if ice_flow_init() or
ice_reset_fxp_resource() fails.
Probably worth opening a bz for later processing.
WDYT?


-- 
David Marchand



More information about the dev mailing list