[dpdk-dev] [PATCH V2] ethdev: add dev configured flag

[David Marchand]

On Wed, Jul 7, 2021 at 11:59 AM Thomas Monjalon <thomas at monjalon.net> wrote:
> > This is problematic, as the following rule does not work:
> >
> > +; Ignore bitfields added in rte_eth_dev_data hole
> > +[suppress_type]
> > +        name = rte_eth_dev_data
> > +        has_data_member_inserted_between = {offset_after(lro),
> > offset_of(rx_queue_state)}
> >
> > On the other hand, a (wrong) rule with "has_data_member_inserted_at =
> > 2" (2 being the wrong offset you can read in abidiff output) works.
> >
> > This might force us to waive all changes to rte_eth_dev_data... not
> > that I am happy about it.
>
> We are not going to do other changes until 21.11, so it could be fine.

Ok, example of a global exception for the structure:

+; Ignore all changes to rte_eth_dev_data
+; Note: we only cared about dev_configured bit addition, but libabigail
+; seems to wrongly compute bitfields offset.
+; https://sourceware.org/bugzilla/show_bug.cgi?id=28060
+[suppress_type]
+        name = rte_eth_dev_data


-- 
David Marchand