[dpdk-dev] [PATCH v7 14/19] net/ngbe: add device start and stop operations

[Andrew Rybchenko]

On 7/6/21 12:55 PM, Jiawen Wu wrote:
> Setup MSI-X interrupt, complete PHY configuration and set device link
> speed to start device. Disable interrupt, stop hardware and clear queues
> to stop device.
> 
> Signed-off-by: Jiawen Wu <jiawenwu at trustnetic.com>

WARNING:MSLEEP: msleep < 20ms can sleep for up to 20ms; see
Documentation/timers/timers-howto.rst
#242: FILE: drivers/net/ngbe/base/ngbe_phy_mvl.c:70:
+                       msleep(1);

Any comments?



CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#1102: FILE: drivers/net/ngbe/ngbe_rxtx.c:531:
+
+}

Above must be fixed.

[snip]