[dpdk-dev] [PATCH v2] examples/power: add baseline mode to PMD power
Thomas Monjalon
thomas at monjalon.net
Sat Jul 10 08:43:55 CEST 2021
23/06/2021 16:14, Burakov, Anatoly:
> On 23-Jun-21 1:09 PM, David Hunt wrote:
> > On 23/6/2021 11:14 AM, Burakov, Anatoly wrote:
> >> On 22-Jun-21 3:07 PM, David Hunt wrote:
> >>> The PMD Power Management scheme currently has 3 modes,
> >>> scale, monitor and pause. However, it would be nice to
> >>> have a baseline mode for easy comparison of power savings
> >>> with and without these modes.
> >>>
> >>> This patch adds a 'baseline' mode were the pmd power
> >>> management is not enabled. Use --pmg-mgmt=baseline.
> >>>
> >>> Signed-off-by: David Hunt <david.hunt at intel.com>
> >>>
> >>> ---
> >>> - if (app_mode == APP_MODE_PMD_MGMT) {
> >>> + if ((app_mode == APP_MODE_PMD_MGMT) &&
> >>> + (baseline_enabled == false)) {
> >>
> >> Nitpicking, !baseline_enabled
> >>
> > Thanks, Anatoly. I don't feel a re-spin is needed for this, but I'll
> > take this format into consideration for future patches, OK?
>
> Yep, i'm fine either way. Maybe someone can fix it on apply :)
Applied with the change.
More information about the dev
mailing list