[dpdk-dev] [EXT] [PATCH v8 15/16] test/crypto: add data-unit and wrapped vectors

[Akhil Goyal]

> >
> > > The AES-XTS algorithm supports using a wrapped key.
> > > In AES-XTS the data-unit defines the data block size to be
> > > encrypted\decrypted.
> > >
> > > Add AES-XTS vectors with a wrapped key.
> > > Add a variable stating whether the key is wrapped or not.
> > > Add the AES-XTS data-unit.
> > >
> > > Signed-off-by: Shiri Kuzin <shirik at nvidia.com>
> > > Acked-by: Matan Azrad <matan at nvidia.com>
> > > ---
> > >  app/test/test_cryptodev.h                  |    2 +-
> > >  app/test/test_cryptodev_aes_test_vectors.h | 1340
> ++++++++++++++++++++
> > >  app/test/test_cryptodev_blockcipher.c      |   10 +-
> > >  app/test/test_cryptodev_blockcipher.h      |    2 +
> > >  4 files changed, 1352 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/app/test/test_cryptodev.h b/app/test/test_cryptodev.h
> > > index 262e545ee6..f35dba6837 100644
> > > --- a/app/test/test_cryptodev.h
> > > +++ b/app/test/test_cryptodev.h
> > > @@ -19,7 +19,7 @@
> > >  #define DEFAULT_NUM_XFORMS              (2)
> > >  #define NUM_MBUFS                       (8191)
> > >  #define MBUF_CACHE_SIZE                 (256)
> > > -#define MBUF_DATAPAYLOAD_SIZE		(2048 +
> > > DIGEST_BYTE_LENGTH_SHA512)
> > > +#define MBUF_DATAPAYLOAD_SIZE		(4096 +
> > > DIGEST_BYTE_LENGTH_SHA512)
> >
> > Any specific reason this size is increased. It may negatively impact on other
> > platforms Which have lesser memory available.
> > We need a reason to change the existing MACROS which affect all drivers.
> 
> The reason here is that mlx device can support up to 4K data payload size,  I
> assume even we haven't changed it, there will still be other vendor can
> support more big value later.
> After the rebase today, please try the patches on other platforms in case
> everything is still good.
> 
Can you make this particular change as a separate patch outside your series?
This would need ack from other PMD owners as well.