[dpdk-dev] [EXT] [PATCH v9 00/15] drivers: introduce mlx5 crypto PMD

[Suanming Mou]

Hi Akhil,

> -----Original Message-----
> From: Suanming Mou
> Sent: Wednesday, July 21, 2021 8:27 AM
> To: Akhil Goyal <gakhil at marvell.com>; Shiri Kuzin <shirik at nvidia.com>
> Cc: Matan Azrad <matan at nvidia.com>; david.marchand at redhat.com;
> dev at dpdk.org
> Subject: RE: [EXT] [PATCH v9 00/15] drivers: introduce mlx5 crypto PMD
> 
> Hi Akhil,
> 
> > -----Original Message-----
> > From: Akhil Goyal <gakhil at marvell.com>
> > Sent: Wednesday, July 21, 2021 5:02 AM
> > To: Suanming Mou <suanmingm at nvidia.com>; Shiri Kuzin
> > <shirik at nvidia.com>
> > Cc: Matan Azrad <matan at nvidia.com>; david.marchand at redhat.com;
> > dev at dpdk.org
> > Subject: RE: [EXT] [PATCH v9 00/15] drivers: introduce mlx5 crypto PMD
> >
> > > > v2:
> > > > - Add data-path part.
> > > >
> > > > v3:
> > > > - Rebase.
> > > >
> > > > v4:
> > > > - Rebase + Address the following Akhil comments:
> > > > - Set HW feature flag in the capability patch.
> > > > - Fix mp object release in session clear.
> > > > - Some spelling and word missing in doc.
> > > > - Squash data-unit adjustment to the session operations commit.
> > > > - Wording: device argument -> devarg.
> > > >
> > > > v5:
> > > > - Add mlx5 crypto tests into test library.
> > > > - Update documentation according to Akhil comments.
> > > > - Fix memory region management.
> > > > - Fix multi segment case in data-path code.
> > > > - Split documentation to the correct commits according to Akhil
> > > >   comments.
> > > > - Rebase to new version.
> > > > - Change license to Nvidia license.
> > > >
> > > > v6:
> > > > - Rebase to new version.
> > > > - Address David's comment and update log accordingly.
> > > > - Update testing app commits as suggested by Akhil.
> > > >
> > > > v7:
> > > > - Rebase to new version.
> > > > - Add scatter gather and OOP test cases.
> > > >
> > > > v8:
> > > > - Add a test case that was removed by error.
> > > >
> > > > v9:
> > > > - Reorganize the basic operation commit.
> > > > - Move the seesion operation commit after QP patch.
> > > > - Fix coding style.
> > > > - Move the rel_notes to the last PMD change.
> > > > - Move the mlx5 test code to last.
> > > > - Rename the driver name to crypto_mlx5.
> > > > - Split the MBUF_DATAPAYLOAD_SIZE update out of the series.
> > > >
> > > Series Acked-by: Akhil Goyal <gakhil at marvell.com>
> > >
> > > Applied to dpdk-next-crypto
> > > Updated MAINTAINERS file for ownership of  mlx5.rst and mlx5.ini
> > > files Fixed some typos while applying patches.
> >
> > I am getting error while cross-compile arm on x86. Can you check.
> > Please send a fix if it is a genuine issue, I will squash in the original commit.
> >
> > meson build.octeontx2 --cross-file
> > config/arm/arm64_octeontx2_linux_gcc - Dexamples=all --buildtype=debug
> > ninja -C build.octeontx2 [906/2513] Linking target
> drivers/librte_common_mlx5.so.21.3.
> > FAILED: drivers/librte_common_mlx5.so.21.3
> > aarch64-linux-gnu-gcc  -o drivers/librte_common_mlx5.so.21.3
> > 'drivers/a715181@@rte_common_mlx5 at sha/meson-
> > generated_.._rte_common_mlx5.pmd.c.o'
> >
> 'drivers/a715181@@tmp_rte_common_mlx5 at sta/common_mlx5_mlx5_devx_
> > cmds.c.o'
> >
> 'drivers/a715181@@tmp_rte_common_mlx5 at sta/common_mlx5_mlx5_comm
> > on.c.o'
> >
> 'drivers/a715181@@tmp_rte_common_mlx5 at sta/common_mlx5_mlx5_comm
> > on_mp.c.o'
> >
> 'drivers/a715181@@tmp_rte_common_mlx5 at sta/common_mlx5_mlx5_comm
> > on_mr.c.o'
> >
> 'drivers/a715181@@tmp_rte_common_mlx5 at sta/common_mlx5_mlx5_malloc
> > .c.o'
> >
> 'drivers/a715181@@tmp_rte_common_mlx5 at sta/common_mlx5_mlx5_comm
> > on_pci.c.o'
> >
> 'drivers/a715181@@tmp_rte_common_mlx5 at sta/common_mlx5_mlx5_comm
> > on_devx.c.o'
> >
> 'drivers/a715181@@tmp_rte_common_mlx5 at sta/common_mlx5_mlx5_comm
> > on_utils.c.o'
> >
> 'drivers/a715181@@tmp_rte_common_mlx5 at sta/common_mlx5_linux_mlx5_
> > nl.c.o'
> >
> 'drivers/a715181@@tmp_rte_common_mlx5 at sta/common_mlx5_linux_mlx5_
> > common_os.c.o'
> >
> 'drivers/a715181@@tmp_rte_common_mlx5 at sta/common_mlx5_linux_mlx5_
> > common_verbs.c.o'
> >
> 'drivers/a715181@@tmp_rte_common_mlx5 at sta/common_mlx5_linux_mlx5_
> > glue.c.o' -Wl,--as-needed -Wl,--no-undefined -shared -fPIC
> > -Wl,--start-group -
> > Wl,-soname,librte_common_mlx5.so.21 -Wl,--no-as-needed -pthread -lm
> > -ldl
> > lib/librte_hash.so.21.3 lib/librte_eal.so.21.3
> > lib/librte_kvargs.so.21.3
> > lib/librte_telemetry.so.21.3 lib/librte_net.so.21.3
> > lib/librte_mbuf.so.21.3
> > lib/librte_mempool.so.21.3 lib/librte_ring.so.21.3
> > lib/librte_rcu.so.21.3
> > lib/librte_pci.so.21.3 drivers/librte_bus_pci.so.21.3 -Wl,--version-
> > script=/home/cavium/up/dpdk-next-crypto/drivers/common/mlx5/version.ma
> > p /home/cavium/up/mlx/rdma-core/build/lib/libmlx5.so -Wl,-
> > rpath,/home/cavium/up/mlx/rdma-core/build/lib
> > /home/cavium/up/mlx/rdma- core/build/lib/libibverbs.so -Wl,--end-group
> > -Wl,- rpath,/home/cavium/up/mlx/rdma-core/build/lib '-Wl,-
> > rpath,$ORIGIN/../lib:$ORIGIN/'
> > -Wl,-rpath-link,/home/cavium/up/dpdk-next-
> > crypto/build.octeontx2/lib -Wl,-rpath-link,/home/cavium/up/dpdk-next-
> > crypto/build.octeontx2/drivers
> > /home/cavium/tools/marvell-tools-1013.0/bin/../lib/gcc/aarch64-marvell
> > -linux-
> > gnu/10.1.0/../../../../aarch64-marvell-linux-gnu/bin/ld:
> > /home/cavium/up/mlx/rdma-core/build/lib/libmlx5.so: error adding symbols:
> > file in wrong format
> > collect2: error: ld returned 1 exit status [915/2513] Generating
> > rte_common_sfc_efx.sym_chk with a meson_exe.py custom command.
> 
> Not sure what's the real issue here, I'm trying to find a local setup to reproduce
> it.

I can't be reproduced the issue on my local setup while cross-compiling.
And double checked the log here, seems the rdma-core libmlx5.so is not correct:
/home/cavium/up/mlx/rdma-core/build/lib/libmlx5.so: error adding symbols: file in wrong format
I assume you will see the same issue even when you don't have the crypto patch set?
Do you get the error only when you applied the crypto patch set?

Thanks,
SuanmingMou