[dpdk-dev] [PATCH] bus/vmbus: Fix crash when handling packets in secondary process

Thomas Monjalon thomas at monjalon.net
Thu Jul 22 21:15:48 CEST 2021


21/07/2021 02:17, Long Li:
> From: Stephen Hemminger <sthemmin at microsoft.com>
> > 
> > Looks good, minor comment. You don't have to check for NULL before calling
> > rte_free().
> > Rte_free(NULL) is a NOP like free(NULL).
> > 
> > Sorry for top posting; but if you send to my Microsoft account you are stuck
> > with what Outlook can do...
> > 
> From: jerb <jonathan.erb at banduracyber.com>
> > 
> > Have secondary processes construct their own copy of primary channel with
> > own mappings.
> > 
> > Remove vmbus_channel primary ptr from struct mapped_vmbus_resource as
> > its not used.
> > 
> > Populate virtual memory address "addr" in struct rte_mem_resource for
> > secondary processes as netvsc will attempt to reference it thus causing a crash.
> > It was initialized for primary processes but not for secondary.
> > 
> > Signed-off-by: jerb <jonathan.erb at banduracyber.com>

Please give your complete name.

> Looks good.
> 
> This should also go to stable.

Please send a v2 with Fixes and Cc: stable at dpdk.org lines
as documented in the contributor's guide.
If you don't know how to do, the maintainers can help.

Thank you




More information about the dev mailing list