[dpdk-dev] [PATCH v3 5/6] net/ena: rework RSS configuration

Thomas Monjalon thomas at monjalon.net
Fri Jul 23 15:19:43 CEST 2021


23/07/2021 13:52, Thomas Monjalon:
> 23/07/2021 11:49, Michał Krawczyk:
> > pt., 23 lip 2021 o 11:43 Thomas Monjalon <thomas at monjalon.net> napisał(a):
> > > 23/07/2021 11:39, Michał Krawczyk:
> > > > pt., 23 lip 2021 o 11:22 Thomas Monjalon <thomas at monjalon.net> napisał(a):
> > > > > 14/07/2021 12:43, Michal Krawczyk:
> > > > > > +               PMD_DRV_LOG(WARNING,
> > > > > > +                       "Setting RSS hash fields is not supported. Using default values: 0x%llx\n",
> > > > > > +                       ENA_ALL_RSS_HF);
> > > > > >
> > > > >
> > > > > checkpatch is returning this warning:
> > > > >         Using %l format, prefer %PRI*64 if type is [u]int64_t
> > > > >
> > > > > Indeed rss_hf is uint64_t.
> > 
> > Yeah, sure, casting ENA_RSS_HF to uint64_t in this log should do the
> > trick - I'll fix that in the v4.
> 
> I think you should declare ENA_RSS_HF with UINT64_C()

The real fix is probably to declare all ETH_RSS_*
and other bits in ethdev with the right RTE_BIT* macro.
Call for volunteers to fix that API in DPDK 21.11...




More information about the dev mailing list