[dpdk-dev] [PATCH v2] eventdev: fix event port setup in tx adapter
Thomas Monjalon
thomas at monjalon.net
Fri Jul 30 12:31:35 CEST 2021
30/07/2021 12:24, Jerin Jacob:
> On Wed, Jul 28, 2021 at 4:27 PM Jayatheerthan, Jay
> <jay.jayatheerthan at intel.com> wrote:
> >
> > > -----Original Message-----
> > > From: Jerin Jacob <jerinjacobk at gmail.com>
> > > Sent: Wednesday, July 28, 2021 3:01 PM
> > > To: Jayatheerthan, Jay <jay.jayatheerthan at intel.com>
> > > Cc: Naga Harish K, S V <s.v.naga.harish.k at intel.com>; dev at dpdk.org
> > > Subject: Re: [PATCH v2] eventdev: fix event port setup in tx adapter
>
> > >
> > > >
> > > > >
> > > > > Signed-off-by: Naga Harish K, S V <s.v.naga.harish.k at intel.com>
> > >
> > >
> > > @Naga Harish K, S V Can we remove "," from the Signoff name.
> > >
> > > Some suggestions for consideration in preferred order. Let me know
> > > your preferred Signoff name, I will change it accordingly.
> > >
> > > Naga Harish <s.v.naga.harish.k at intel.com>
> > >
> > > or
> > >
> > > Naga Harish K <s.v.naga.harish.k at intel.com>
> > >
> > > or
> > >
> > > Naga Harish K S V <s.v.naga.harish.k at intel.com>
> >
> > This option is good. (Harish is out and hence I am responding)
>
> 1) Option 'Signed-off-by: Naga Harish K S V
> <s.v.naga.harish.k at intel.com> is warned by checkpatch
>
> [for-main]dell[dpdk-next-eventdev] $ ./devtools/checkpatches.sh -n 1
>
> ### eventdev: fix event port setup in Tx adapter
>
> WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email name
> mismatch: 'From: "Naga Harish K, S V" <s.v.naga.harish.k at intel.com>'
> != 'Signed-off-by: Naga Harish K S V <s.v.naga.harish.k at intel.com>'
>
> 2) Option 'Signed-off-by: Naga Harish K, S V
> <s.v.naga.harish.k at intel.com>' is warning by check-git-log.sh
>
> [for-main]dell[dpdk-next-eventdev] $ ./devtools/check-git-log.sh -n 1
> Wrong tag:
> Signed-off-by: Naga Harish K, S V <s.v.naga.harish.k at intel.com>
>
>
> @thomas @David Marchand
>
> Could you suggest what Sign-off to take?
The first option is probably OK but the problem is a mismatch with the author name.
Make sure to change the authorship with --amend --author=
More information about the dev
mailing list