[dpdk-dev] [PATCH] doc: update sample actions support in mlx5 guide

Thomas Monjalon thomas at monjalon.net
Fri Mar 12 16:51:00 CET 2021


12/03/2021 10:44, Jiawei(Jonny) Wang:
> From: Thomas Monjalon <thomas at monjalon.net>
> > 09/03/2021 14:09, Jiawei Wang:
> > > +  - Supports ``MARK``, ``COUNT``, ``QUEUE``, ``RSS`` as sample actions for
> > NIC Rx sampling/mirroring flow.
> > 
> > "sample actions for NIC Rx sampling" is redundant.
> > I suggest "Supports [...] actions for NIC Rx flow sampling/mirroring."
> > 
> 
> These actions are support in the sample action list, user also can add modify, decap , encap in the NIC RX flow;
> How about this:
> 
> "For NIC RX flow with sample action, Supports [...] actions in the sample action list" ?

Another suggestion:
For NIC Rx flow, supports [...] in the sampling actions list.


> > > +  - Supports ``RAW ENCAP``, ``Port ID`` as sample actions for E-Switch
> > mirroring (sample ratio = 1) flow.
> > 
> > I suggest "Supports [...] actions for E-Switch flow mirroring."
> > 
> > If lines are long, do not hesitate to start a new line after a punctuation.
> > 
> 
> Ok, I will split into two lines.
> 
> Thanks.





More information about the dev mailing list