[dpdk-dev] [PATCH v11 2/2] bus/pci: support MMIO in PCI ioport accessors
谢华伟(此时此刻)
huawei.xhw at alibaba-inc.com
Mon Mar 15 12:25:34 CET 2021
On 2021/3/15 18:19, David Marchand wrote:
>> #else
>> #define IO_COND(addr, is_pio, is_mmio) do { \
>> is_mmio; \
>> } while (0)
>> #endif
> We should not just copy/paste kernel code.
>
> Plus here, this seems a bit overkill.
> And there are other parts in this code that could use some polishing.
>
> What do you think of merging this series as is (now that we got non
> regression reports) and doing such cleanups in followup patches?
I am OK. Yes, we could do some cleanup after it is merged, for example
against vfio, if it is really necessary for virtio PMD only to use vfio
to access IO port.
More information about the dev
mailing list