[dpdk-dev] [PATCH v2 5/6] config: discover libpcap on Windows

[Thomas Monjalon]

25/02/2021 18:42, Dmitry Kozlyuk:
> 2021-02-25 16:33, Bruce Richardson:
> > On Thu, Feb 25, 2021 at 07:04:38PM +0300, Dmitry Kozlyuk wrote:
> > > 2021-02-25 15:02, Ferruh Yigit:  
> > > > On 2/14/2021 2:16 AM, Dmitry Kozlyuk wrote:  
> > > > > WinPcap or Npcap, can be installed anywhere.
> > > > > Add a Meson option to specify SDK path.
> > > > >     
> > > > 
> > > > I am not sure if it is OK to add a meson option for this, can't we use the 
> > > > default path?
> > > > 
> > > > And does this mean we will need to add an option for each dependent library in 
> > > > Windows? If not, why pcap is special?  
> > > 
> > > There are some meson options for SDK paths already. Are they exceptions?
> > >   
> > Right now, yes, they are exceptions, but there is work underway to remove
> > them and just replace them with use of pkg-config. Is there some automatic
> > path discovery mechanism on windows, similar to pkg-config, that can be
> > used rather than having to add explicit dependency paths?
> 
> pkg-config itself works on Windows if installed and given a PKG_CONFIG_PATH.
> 
> Npcap doesn't provide a .pc file, despite libpcap commit 4f6b2b99 having it.

Please work with them to provide a .pc.

> Another quirk is that library is named libpcap.a/wpcap.lib on Unix/Windows.
> I can just handle the name difference and assume it's in the search path.

Yes please avoid adding a meson option for a path.