[dpdk-dev] [PATCH v4 0/8] common/sfc_efx: prepare to introduce vDPA driver

[Ferruh Yigit]

On 3/16/2021 11:30 AM, Andrew Rybchenko wrote:
> On 3/16/21 2:26 PM, Ferruh Yigit wrote:
>> On 3/16/2021 8:58 AM, Andrew Rybchenko wrote:
>>> Update base driver to provide functionality required by vDPA driver.
>>>
>>> Factor out helper functions to be shared by net and vDPA drivers.
>>>
>>> v4:
>>>    - fix Copyright year
>>>
>>> v3:
>>>    - one more attempt to fix windows build breakage
>>>
>>> v2:
>>>    - fix windows build breakage - do not build common/sfc_efx in the case
>>>      of windows
>>>    - remove undefined efx_virtio_* functions from version.map (since
>>>      EFSYS_OPT_VIRTIO is disabled)
>>>
>>> Vijay Kumar Srivastava (6):
>>>     common/sfc_efx/base: add virtio build dependency
>>>     common/sfc_efx/base: add support to get virtio features
>>>     common/sfc_efx/base: add support to verify virtio features
>>>     common/sfc_efx: add support to get the device class
>>>     net/sfc: skip driver probe for incompatible device class
>>>     drivers: add common driver API to get efx family
>>>
>>> Vijay Srivastava (2):
>>>     common/sfc_efx/base: add base virtio support for vDPA
>>>     common/sfc_efx/base: add API to get VirtQ doorbell offset
>>>
>>
>> The driver adds vDPA support, I believe it worth mentioning in the
>> driver documentation and in the release notes, can you please send a
>> new version with documentation updates?
> 
> No, no. It is just preparations to introduce the vDPA driver.
> vDPA drier will be added in a subsequent patches and I'll
> ensure that it is mentioned in release notes etc.
> 

Got it, that answers a few of unused functions too.. Please be sure to document.