[dpdk-dev] [PATCH v2 2/4] common/mlx5: enable debug logs dynamically

Ferruh Yigit ferruh.yigit at intel.com
Wed Mar 17 18:39:25 CET 2021


On 3/9/2021 9:48 AM, Thomas Monjalon wrote:
> Most debug logs are using DRV_LOG(DEBUG,)
> but some were using DEBUG().
> The macro DEBUG is doing nothing if not compiled with
> RTE_LIBRTE_MLX5_DEBUG.
> 
> As it is not used in the data path, the macro DEBUG
> can be replaced with DRV_LOG.
> Then all debug logs can be enabled at runtime with:
> 	--log-level pmd.net.mlx5:debug
> 
> Signed-off-by: Thomas Monjalon <thomas at monjalon.net>

Similar comment for the mlx4 one, copying here:

Why 'RTE_LIBRTE_MLX5_DEBUG' exists at first place?

It seems is is used both for data and control path, can you extend the patch for:
1- Remove #ifdef from control path
2- Replace with 'RTE_ETHDEV_DEBUG_RX' & 'RTE_ETHDEV_DEBUG_TX' for data path,
    please see: https://patches.dpdk.org/project/dpdk/list/?series=15738
3- Remove 'RTE_LIBRTE_MLX5_DEBUG' completely, if not removed document it in the
    driver documentation as supported config file


Both for 'mlx4' and 'mlx5', I will continue with existing patch, but can it be 
possible to make additional patches to address above issues?


More information about the dev mailing list