[dpdk-dev] [PATCH v3 0/4] net: replace Windows networking shim

[Ranjit Menon]

On 3/13/2021 2:22 PM, Dmitry Kozlyuk wrote:
> Networking header shim in Windows EAL conflicts with system headers and
> tries to provide POSIX compatibility out of scope for DPDK.
> Remove dependency on POSIX headers from libraries supported on Windows,
> then replace shim with librte_net with workarounds.
>
> A proposed deprecation notice is assumed:
> http://patchwork.dpdk.org/project/dpdk/list/?series=15595
>
> v3: Fix build on FreeBSD for real (CI).
> v2: Fix build on FreeBSD (CI).
>
> Depends-on: series-15513 ("eal/windows: do not expose POSIX symbols")
>
> Dmitry Kozlyuk (4):
>    cmdline: remove POSIX dependency
>    ethdev: remove POSIX dependency
>    net/mlx5: remove POSIX dependency
>    net: replace Windows networking shim
>
>   drivers/net/mlx5/mlx5.h                      |  2 +-
>   drivers/net/mlx5/mlx5_flow.c                 |  4 +--
>   drivers/net/mlx5/mlx5_flow.h                 |  4 +--
>   drivers/net/mlx5/mlx5_mac.c                  |  1 -
>   examples/cmdline/commands.c                  |  1 -
>   examples/cmdline/parse_obj_list.c            |  2 --
>   lib/librte_cmdline/cmdline.c                 |  1 -
>   lib/librte_cmdline/cmdline_parse.c           |  2 --
>   lib/librte_cmdline/cmdline_parse_etheraddr.c |  6 ----
>   lib/librte_cmdline/cmdline_parse_ipaddr.c    |  6 ----
>   lib/librte_cmdline/cmdline_parse_ipaddr.h    |  2 +-
>   lib/librte_eal/windows/include/arpa/inet.h   | 30 ----------------
>   lib/librte_eal/windows/include/netinet/in.h  | 38 --------------------
>   lib/librte_eal/windows/include/netinet/ip.h  | 10 ------
>   lib/librte_eal/windows/include/sys/socket.h  | 24 -------------
>   lib/librte_ethdev/rte_ethdev.c               | 13 +++----
>   lib/librte_ethdev/rte_ethdev_core.h          |  1 -
>   lib/librte_net/rte_ether.h                   | 26 ++++++++++----
>   lib/librte_net/rte_ip.h                      | 18 ++++++++++
>   19 files changed, 49 insertions(+), 142 deletions(-)
>   delete mode 100644 lib/librte_eal/windows/include/arpa/inet.h
>   delete mode 100644 lib/librte_eal/windows/include/netinet/in.h
>   delete mode 100644 lib/librte_eal/windows/include/netinet/ip.h
>   delete mode 100644 lib/librte_eal/windows/include/sys/socket.h
>
Acked-by: Ranjit Menon <ranjit.menon at intel.com>