[dpdk-dev] [PATCH v2] examples/pipeline: support CLI hex args

David Marchand david.marchand at redhat.com
Wed Mar 24 13:31:17 CET 2021


On Wed, Mar 24, 2021 at 1:20 PM Churchill Khangar
<churchill.khangar at intel.com> wrote:
>
> This patch allows specification of integer arguments for the
> CLI commands in hexadecimal and octal as well as decimal.
>
> Signed-off-by: Churchill Khangar <churchill.khangar at intel.com>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu at intel.com>
> ---
>  examples/pipeline/cli.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/examples/pipeline/cli.c b/examples/pipeline/cli.c
> index ae06658..ef49eb8 100644
> --- a/examples/pipeline/cli.c
> +++ b/examples/pipeline/cli.c
> @@ -55,7 +55,7 @@
>         if (!isdigit(*p))

Not directly related to this change, but the isdigit() check is
probably useless.
strtoul returns the first invalid char.

>                 return -EINVAL;
>
> -       val = strtoul(p, &next, 10);
> +       val = strtoul(p, &next, 0);


-- 
David Marchand



More information about the dev mailing list