[dpdk-dev] [PATCH v3 2/2] drivers/net: remove explicit include of legacy filtering

[Ferruh Yigit]

On 3/21/2021 9:00 AM, Thomas Monjalon wrote:
> The header file rte_eth_ctrl.h should not be needed because
> this legacy filtering API is completely replaced with the rte_flow API.
> However some definitions from this file are still used by some drivers,
> but such usage is already covered by an implicit include via rte_ethdev.h.
> 
> Signed-off-by: Thomas Monjalon <thomas at monjalon.net>
> Acked-by: Rosen Xu <rosen.xu at intel.com>
> Acked-by: Hemant Agrawal <hemant.agrawal at nxp.com>
> ---
>   drivers/net/dpaa2/dpaa2_ptp.c       | 1 -
>   drivers/net/iavf/iavf_hash.c        | 1 -
>   drivers/net/ice/ice_acl_filter.c    | 1 -
>   drivers/net/ice/ice_hash.c          | 1 -
>   drivers/net/ice/ice_switch_filter.c | 1 -
>   drivers/net/igc/igc_filter.h        | 1 -
>   drivers/net/ipn3ke/ipn3ke_flow.c    | 1 -

Although this will work, if the above drives are using the defines from the 
header file, isn't it better to include it explicitly?

What is the benefit of including the header implicitly?