[dpdk-dev] [PATCH] eal: standard c++ forbids defining the keyword asm as a macro

Dmitry Kozlyuk dmitry.kozliuk at gmail.com
Wed Mar 24 23:41:47 CET 2021


2021-03-24 14:55 (UTC-0700), Tyler Retzlaff:
> On Wed, Mar 24, 2021 at 06:52:40PM +0100, Thomas Monjalon wrote:
> > 24/03/2021 18:28, Tyler Retzlaff:  
[...]
> > > would you prefer that i change the preprocessor protection to include only
> > > windows? since i'm certain that this will break for any c++ compiler on
> > > windows the moment any stl header is included.  
> > 
> > No, C++ is probably the right scope.
> > 
> > I don't know yet. I would like to understand the global picture,
> > and have it properly documented in this commit log.  
> 
> yep, no problem. i suspect we are probably the only ones using c++ and
> dpdk (though others can speak up if they do too) which may be why this
> has gone unnoticed until now.

You're certainly not the only one:

* Seastar is a C++ userspace TCP/IP stack, ScyllaDB is based on it.
* Click modular router can use DPDK from C++ [1].
* DPDK-based product out company works on is in C++.

Can't speak for Seastar and Click, but we never hit this particular issue.
What is the minimal complete example to reproduce?

[1]:
https://github.com/kohler/click/blob/master/elements/userlevel/fromdpdkdevice.cc


More information about the dev mailing list