[dpdk-dev] [PATCH] net/vmxnet3: build on Windows

[Ferruh Yigit]

On 3/24/2021 6:32 PM, Yong Wang wrote:
> 
> -----Original Message-----
> From: Dmitry Kozlyuk <dmitry.kozliuk at gmail.com>
> Date: Wednesday, March 24, 2021 at 10:50 AM
> To: Yong Wang <yongwang at vmware.com>
> Cc: Ferruh Yigit <ferruh.yigit at intel.com>, "dev at dpdk.org" <dev at dpdk.org>, Narcisa Ana Maria Vasile <navasile at linux.microsoft.com>, Dmitry Malloy <dmitrym at microsoft.com>, Pallavi Kadam <pallavi.kadam at intel.com>
> Subject: Re: [dpdk-dev] [PATCH] net/vmxnet3: build on Windows
> 
>      2021-03-23 17:13 (UTC+0000), Yong Wang:
>      > -----Original Message-----
>      > From: Ferruh Yigit <ferruh.yigit at intel.com>
>      > Date: Tuesday, March 23, 2021 at 9:11 AM
>      > To: Dmitry Kozlyuk <dmitry.kozliuk at gmail.com>, "dev at dpdk.org" <dev at dpdk.org>, Yong Wang <yongwang at vmware.com>
>      > Cc: Narcisa Ana Maria Vasile <navasile at linux.microsoft.com>, Dmitry Malloy <dmitrym at microsoft.com>, Pallavi Kadam <pallavi.kadam at intel.com>
>      > Subject: Re: [dpdk-dev] [PATCH] net/vmxnet3: build on Windows
>      >
>      >     On 2/21/2021 12:55 AM, Dmitry Kozlyuk wrote:
>      >     > Remove OS restriction and update release notes.
>      >     >
>      >     > Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk at gmail.com>
>      >
>      >     Build looks good, but I wonder if anyone tested the driver on Windows.
>      >
>      >     Yong,
>      >
>      >     Do you have any plan to test the driver on Windows, should we wait your ack?
>      >
>      > Ferruh,
>      >
>      > Unfortunately I don't have any Windows setup to test this change.  Do you know what kind of tests have been done for this change?
> 
>      For the record, I tested the following setup with Windows Server 2019 in QEMU
>      (-device vmxnet3) before submitting the patch:
> 
>      [ping     ]           [                     ]           [     ping]
>      [OS       ]           [    dpdk-skeleton    ]           [       OS]
>      [virtio---]--sockets--[---vmxnet3 vmxnet3---]--sockets--[---virtio]
>      [Debian VM]           [     Windows VM      ]           [Debian VM]
> 
>      Debian VMs successfully ping'd each other with Windows forwarding.
> 
> Thanks Dmitri for the testing results.  It will be good if you can try some basic tcp/udp traffic as well.
> 
> Acked-by: Yong Wang <yongwang at vmware.com>
> 

Applied to dpdk-next-net/main, thanks.

Added the above test detail to commit log for record.