[dpdk-dev] [PATCH 2/6] net/hns3: fix compiling error for using SVE algorithm

Ferruh Yigit ferruh.yigit at intel.com
Mon Mar 29 18:10:08 CEST 2021


On 3/23/2021 1:45 PM, Min Hu (Connor) wrote:
> From: Huisong Li <lihuisong at huawei.com>
> 
> The 'queue_full_cnt' stats have been encapsulated in 'dfx_stats'.
> However, the modification in the SVE algorithm is omitted.
> As a result, the driver fails to be compiled when the SVE
> algorithm is used.
> 
> Fixes: 9b77f1fe303f ("net/hns3: encapsulate DFX stats in datapath")
> 
> Signed-off-by: Huisong Li <lihuisong at huawei.com>
> Signed-off-by: Min Hu (Connor) <humin29 at huawei.com>
> ---
>   drivers/net/hns3/hns3_rxtx_vec_sve.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/hns3/hns3_rxtx_vec_sve.c b/drivers/net/hns3/hns3_rxtx_vec_sve.c
> index f8655fa..e1a1731 100644
> --- a/drivers/net/hns3/hns3_rxtx_vec_sve.c
> +++ b/drivers/net/hns3/hns3_rxtx_vec_sve.c
> @@ -439,7 +439,7 @@ hns3_xmit_fixed_burst_vec_sve(void *__restrict tx_queue,
>   
>   	nb_pkts = RTE_MIN(txq->tx_bd_ready, nb_pkts);
>   	if (unlikely(nb_pkts == 0)) {
> -		txq->queue_full_cnt++;
> +		txq->dfx_stats.queue_full_cnt++;
>   		return 0;
>   	}
>   
> 

Hi Connor,

This is a very obvious build error, I am concerned how this is released. Do you 
have any internal testing?

+ Aaron & Honnappa,

If we can have a build test in our public CI with SVE?




More information about the dev mailing list