[dpdk-dev] [PATCH v3 1/8] app/testpmd: store VXLAN/NVGRE encap data globally

[Ferruh Yigit]

On 3/17/2021 9:26 AM, Salem Sol wrote:
> From: Jiawei Wang <jiaweiw at nvidia.com>
> 
> With the current code the VXLAN/NVGRE parsing routine
> stored the configuration of the header on stack, this
> might lead to overwriting the data on the stack.
> 
> This patch stores the external data of vxlan and nvgre encap
> into global data as a pre-step to supporting vxlan and nvgre
> encap as a sample actions.
> 

I didn't get what was on stack and moved in to the global data, can you please 
elaborate.

For example for nvgre, 'action_nvgre_encap_data' is pointer in stack but the 
actual object is 'ctx->object', so it is not really in the stack.

Tough, OK to refactor and split the function as preparation to support the 
sample action.

> Signed-off-by: Jiawei Wang <jiaweiw at nvidia.com>

<...>

> -/** Parse VXLAN encap action. */
> +/** Setup VXLAN encap configuration. */
>   static int
> -parse_vc_action_vxlan_encap(struct context *ctx, const struct token *token,
> -			    const char *str, unsigned int len,
> -			    void *buf, unsigned int size)
> +parse_setup_vxlan_encap_data
> +		(struct action_vxlan_encap_data *action_vxlan_encap_data)

Can you please fix the syntax, I guess this is done to keep within in 80 column 
limit, but from readability perspective I think better to go over the 80 column 
a little instead of breaking the line like this.

<...>

> +/** Setup NVGRE encap configuration. */
> +static int
> +parse_setup_nvgre_encap_data
> +		(struct action_nvgre_encap_data *action_nvgre_encap_data)
> +{
> +	if (!action_nvgre_encap_data)
> +		return -1;

This is a static function, and the input of it is in our control, so not sure if 
we should verify the input here.
But if we need to, can you please check the return value of this function where 
it is called.