[dpdk-dev] [PATCH v8 5/5] ethdev: merge driver ops to get all xstats names and by ID

Andrew Rybchenko andrew.rybchenko at oktetlabs.ru
Fri Oct 1 11:06:46 CEST 2021


On 9/30/21 7:47 PM, Ferruh Yigit wrote:
> On 9/30/2021 5:05 PM, Andrew Rybchenko wrote:
>> All xstats names may be retrieved passing NULL ids.
>>
>> If a driver does not support getting names by IDs, the callback should
>> return -ENOTSUP on attempt to use it. If so, the request is handled
>> on ethdev layer by getting all names and filtering out requested only.
>>
> 
> Since '-ENOTSUP' has special meaning (request ethdev layer fallback), I think it
> would be good to explicitly document this in the dev_ops comment.

Yes, good idea. Done in v9.

> 
>> Signed-off-by: Andrew Rybchenko <andrew.rybchenko at oktetlabs.ru>



More information about the dev mailing list