[dpdk-dev] Recent change to make rte_cryptodev_pmd.h internal prevents some important functionality

[Zhang, Roy Fan]

Hi Akhil,

This isn’t what our concern was – our concern was rte_cryptodev_close() may not remove the memory complete as rte_cryptodev_pmd_destroy() did.
Our research result towards this was if the PMD could act more throughout to make rte_cryptodev_close() working same as rte_cryptodev_pmd_destroy().

What Paul’s concern is valid: We DO NOT have a way to release a queue pair manually anymore, and releasing queue pair to me should not be blocked from public API access.
To resolve this problem we should have a public queue_pair_release() function in the cryptodev. If you are ok I can send a patch for 21.11 right away.

Regards,
Fan


From: Akhil Goyal <gakhil at marvell.com>
Sent: Monday, October 4, 2021 7:45 AM
To: Luse, Paul E <paul.e.luse at intel.com>; dev at dpdk.org; Zhang, Roy Fan <roy.fan.zhang at intel.com>
Cc: matan at nvidia.com; hemant.agrawal at nxp.com
Subject: RE: Recent change to make rte_cryptodev_pmd.h internal prevents some important functionality

Hi Paul,

Similar comment was discussed in ML for fips_validation app.
https://mails.dpdk.org/archives/dev/2021-August/217781.html

I believe Fan is working on it to fix the issue.
Fan, Could you please share the update.

Regards,
Akhil

Note: Please CC maintainers for a prompt response, or else mails can be skipped.

From: Luse, Paul E <paul.e.luse at intel.com<mailto:paul.e.luse at intel.com>>
Sent: Sunday, October 3, 2021 3:14 AM
To: dev at dpdk.org<mailto:dev at dpdk.org>
Cc: Akhil Goyal <gakhil at marvell.com<mailto:gakhil at marvell.com>>; matan at nvidia.com<mailto:matan at nvidia.com>; Zhang, Roy Fan <roy.fan.zhang at intel.com<mailto:roy.fan.zhang at intel.com>>; hemant.agrawal at nxp.com<mailto:hemant.agrawal at nxp.com>
Subject: [EXT] Recent change to make rte_cryptodev_pmd.h internal prevents some important functionality

External Email
________________________________
Hi Everyone,

I sent this last week and haven’t heard back – apologize if I missed the response but if not here it is again…

We use cryptodev in SPDK and included rte_cryptodev_pmd.h so that we may release qpair memory that was allocated when we called rte_cryptodev_queue_pair_setup().  We’d do so by calling the function pointer queue_pair_release() which I believe is the prescribed way to do this.

The DPDK change in question is here: https://github.com/DPDK/dpdk/commit/af668035f7f492424b2e199f155690815944a8ca<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_DPDK_dpdk_commit_af668035f7f492424b2e199f155690815944a8ca&d=DwMF-g&c=nKjWec2b6R0mOyPaz7xtfQ&r=DnL7Si2wl_PRwpZ9TWey3eu68gBzn7DkPwuqhd6WNyo&m=JtjV1tR2S7GKiUDbCzH0F3Eb5a0srzYbypWQ7frSYlM&s=KPcZHMXJD19T_7amxWdYShvis2l7nWAnfs-nJ85FVto&e=>

Question: Is there another way for us to release this memory? I’ve looked through the public API and nothing stands out.

Thanks
Paul