[dpdk-dev] [dpdk-stable] [PATCH] net/ice/base: fix build error for GCC 4.8.5

[Ferruh Yigit]

On 10/5/2021 2:57 PM, David Marchand wrote:
> On Tue, Oct 5, 2021 at 2:07 PM Aman Singh <aman.deep.singh at intel.com> wrote:
>>
>> Code changes done for build issue as reported in Bug 817
>> error: dereferencing type-punned pointer will break strict-aliasing rules.
>> added union to avoid pointer dereferencing
>>
> 
> About the title, Ali reproduced the issue with other versions of gcc.
> 
> This patch touches base/ code, is Intel ok with this?
> Else, we could consider disabling strict aliasing for the base driver, like
> $ git grep alias '**/base/meson.build'
> drivers/net/fm10k/base/meson.build:    '-Wno-strict-aliasing',
> '-Wno-format-extra-args',
> drivers/net/i40e/base/meson.build:        '-Wno-strict-aliasing',
> '-Wno-unused-but-set-variable',
> drivers/net/qede/base/meson.build:        '-Wno-strict-aliasing',
> 

It has some complications to update the shared code from the DPDK, but for this
case the fix seems simple and valid, so I am for getting the fix and work on to
propagate the fix to the shared code, instead of disable the warning directly.

Mainly Qi and Beilei will be managing the shared code part, if shared code
comes with different solution, we can send an incremental patch to replace
this fix.

Briefly I am for getting the patch, hence:
Acked-by: Ferruh Yigit <ferruh.yigit at intel.com>

> 
> Bugzilla ID: 817
> 
>> Fixes: 39925373a333 ("net/ice/base: add parser execution main loop")
> 
> No Cc: stable, this is a regression in main.
> 
>> Signed-off-by: Aman Singh <aman.deep.singh at intel.com>
> 
> Tested-by: David Marchand <david.marchand at redhat.com>
> 
>