[dpdk-dev] [PATCH v1 1/5] devtools: script to remove unused headers includes

[Thomas Monjalon]

06/10/2021 18:28, Bruce Richardson:
> On Wed, Oct 06, 2021 at 04:19:46PM +0100, Morrissey, Sean wrote:
> > 
> > On 06/10/2021 14:37, Thomas Monjalon wrote:
> > > 04/10/2021 12:10, Sean Morrissey:
> > > > This script can be used for removing headers flagged for removal by the
> > > > include-what-you-use (IWYU) tool. The script has the ability to remove
> > > > headers from specified sub-directories or dpdk as a whole.
> > > My fear is that it could flag an include as useless,
> > > while it is required for a different system (BSD, Windows).
> > > 
> > > 
> > Hi Thomas,
> > 
> > Stephen raised a similar concern. Please see Bruce's reply here: https://patches.dpdk.org/project/dpdk/cover/20211004101058.2396458-1-sean.morrissey@intel.com/
> > 
> One additional data point. Checking the output of a run I did of IWYU a
> month or two ago, shows 2254 header includes that IWYU thinks should be
> removed. With that sort of scale of an issue, I think automation will be
> needed.

I agree to integrate this tool, but we must make clear there are false positives.
Please add a warning when running it.