[dpdk-dev] [PATCH v4] ethdev: replace bit shifts with macros

Ferruh Yigit ferruh.yigit at intel.com
Thu Oct 7 19:32:49 CEST 2021


On 10/7/2021 4:48 PM, Thomas Monjalon wrote:
> The macros RTE_BIT32 and RTE_BIT64 are used to replace bit shifts.
> The macro UINT64C is also used to replace remaining occurrences of ULL.
> 
> The bit shifts of ETH_RSS_LEVEL_* are kept for aesthetic reason.
> 
> The API of rte_mtr and rte_tm is using enums for 64-bit variables.
> As they are enums, unsigned bit cannot be used.
> 
> Signed-off-by: Thomas Monjalon <thomas at monjalon.net>
> Reviewed-by: Andrew Rybchenko <andrew.rybchenko at oktetlabs.ru>
> ---
> v2: use RTE_BIT32 in enums
> v3: rebase on main
> v4: keep enums untouched
> ---
>   lib/ethdev/rte_ethdev.c |  16 ++---
>   lib/ethdev/rte_ethdev.h | 129 ++++++++++++++++++++--------------------
>   lib/ethdev/rte_flow.c   |   4 +-
>   lib/ethdev/rte_flow.h   |   6 +-
>   4 files changed, 78 insertions(+), 77 deletions(-)
> 

Is 'ETH_RSS_L4_CHKSUM' left unchanged intentionally?

#define ETH_RSS_L4_CHKSUM          (1ULL << 35)



More information about the dev mailing list