[dpdk-dev] [PATCH] usertools/telemetry: add listing of available file prefixes
Walsh, Conor
conor.walsh at intel.com
Fri Oct 8 10:20:46 CEST 2021
<snip>
>
> >+
> >+def list_fp():
> >+ """ List all available file-prefixes to user """
> >+ print("Valid file-prefixes:\n")
>
> Nit: I think it might be cleaner to move this down to just before the file
> prefixes print out, so it doesn't print out when no apps are available.
>
> >+ path = get_dpdk_runtime_dir('')
> >+
> >+ sockets = glob.glob(os.path.join(path, "*", SOCKET_NAME + "*"))
> >+ prefixes = []
> >+ if not sockets:
> >+ print("\tNo DPDK apps with telemetry enabled available")
> >+ for s in sockets:
> >+ prefixes.append(os.path.relpath(os.path.dirname(s), start=path))
> >+ for p in sorted(set(prefixes)):
> >+ print(p)
> >+ print_socket_options(p, glob.glob(os.path.join(path, p,
> >+ SOCKET_NAME +
> >+ "*")))
> <snip>
>
> Asides from that one small comment,
>
> Acked-by: Ciara Power <ciara.power at intel.com>
>
> Thanks!
Hi Ciara,
Thanks for the ack, I will address your comment in v2.
/Conor.
More information about the dev
mailing list