[dpdk-dev] [PATCH v3 5/5] examples/l3fwd-power: support virtio/vhost

[Li, Miao]

Hi Chenbo,

> -----Original Message-----
> From: Xia, Chenbo <chenbo.xia at intel.com>
> Sent: Wednesday, September 29, 2021 2:53 PM
> To: Li, Miao <miao.li at intel.com>; dev at dpdk.org
> Cc: maxime.coquelin at redhat.com; david.marchand at redhat.com
> Subject: RE: [PATCH v3 5/5] examples/l3fwd-power: support virtio/vhost
> 
> > -----Original Message-----
> > From: Li, Miao <miao.li at intel.com>
> > Sent: Friday, September 24, 2021 6:23 PM
> > To: dev at dpdk.org
> > Cc: Xia, Chenbo <chenbo.xia at intel.com>; maxime.coquelin at redhat.com; Li,
> Miao
> > <miao.li at intel.com>
> > Subject: [PATCH v3 5/5] examples/l3fwd-power: support virtio/vhost
> >
> > In l3fwd-power, there is default port configuration which requires
> > RSS and IPV4/UDP/TCP checksum. Once device does not support these,
> > the l3fwd-power will exit and report an error.
> > This patch updates the port configuration based on device capabilities
> > after getting the device information to support devices like virtio
> > and vhost.
> >
> > Signed-off-by: Miao Li <miao.li at intel.com>
> > ---
> >  examples/l3fwd-power/main.c | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c
> > index aa7b8db44a..14ae87a9d5 100644
> > --- a/examples/l3fwd-power/main.c
> > +++ b/examples/l3fwd-power/main.c
> > @@ -2637,6 +2637,11 @@ main(int argc, char **argv)
> >  				local_port_conf.rx_adv_conf.rss_conf.rss_hf);
> >  		}
> >
> > +		if (local_port_conf.rx_adv_conf.rss_conf.rss_hf == 0)
> > +			local_port_conf.rxmode.mq_mode =
> ETH_MQ_RX_NONE;
> > +		local_port_conf.rxmode.offloads &= dev_info.rx_offload_capa;
> > +		port_conf.rxmode.offloads = local_port_conf.rxmode.offloads;
> > +
> >  		ret = rte_eth_dev_configure(portid, nb_rx_queue,
> >  					(uint16_t)n_tx_queue,
> &local_port_conf);
> >  		if (ret < 0)
> > --
> > 2.25.1
> 
> Just as David suggested, I think we'd better consider RFC 1812, if HW does not
> support RX IP CKSUM offload, check IP CKSUM in is_valid_ipv4_pkt.

I will fix it in the next version.

Thanks,
Miao

> 
> Thanks,
> Chenbo