[dpdk-dev] [dpdk-dev v3] app: fix buffer overrun

Przemyslaw Zegan przemyslawx.zegan at intel.com
Mon Oct 11 10:04:52 CEST 2021


This patch fixes a possible buffer overrun problem in crypto perf test.
Previously when user configured aad size is over 12 bytes the copy of template aad will cause a buffer overrun.
The problem is fixed by only copy up to 12 bytes of aad template.

Fixes: 8a5b494a7f99 ("app/test-crypto-perf: add AEAD parameters")
Cc: pablo.de.lara.guarch at intel.com

Signed-off-by: Przemyslaw Zegan <przemyslawx.zegan at intel.com>
---
v3:
- replaced hardcoded values by sizeof(aad)

 app/test-crypto-perf/cperf_test_vectors.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/test-crypto-perf/cperf_test_vectors.c b/app/test-crypto-perf/cperf_test_vectors.c
index 2c7e314ec8..271e91c13c 100644
--- a/app/test-crypto-perf/cperf_test_vectors.c
+++ b/app/test-crypto-perf/cperf_test_vectors.c
@@ -555,8 +555,8 @@ cperf_test_vector_get_dummy(struct cperf_options *options)
 				return NULL;
 			}
 
-			if(options->aead_aad_sz > 12)
-				options->aead_aad_sz = 12;
+			if(options->aead_aad_sz > sizeof(aad))
+				options->aead_aad_sz = sizeof(aad);
 
 			memcpy(t_vec->aad.data, aad, options->aead_aad_sz);
 			t_vec->aad.phys_addr = rte_malloc_virt2iova(t_vec->aad.data);
-- 
2.30.2



More information about the dev mailing list