[dpdk-dev] [PATCH] net/softnic: remove useless address check

[Ferruh Yigit]

On 10/13/2021 4:54 PM, Singh, Jasvinder wrote:
> 
> 
>> -----Original Message-----
>> From: Yigit, Ferruh <ferruh.yigit at intel.com>
>> Sent: Monday, October 4, 2021 6:27 PM
>> To: Singh, Jasvinder <jasvinder.singh at intel.com>; Dumitrescu, Cristian
>> <cristian.dumitrescu at intel.com>
>> Cc: Yigit, Ferruh <ferruh.yigit at intel.com>; dev at dpdk.org
>> Subject: [PATCH] net/softnic: remove useless address check
>>
>> Reported by "gcc (GCC) 12.0.0 20211003 (experimental)":
>>
>> ./drivers/net/softnic/rte_eth_softnic_cli.c:
>> 	In function ‘tmgr_hierarchy_default’:
>> ./drivers/net/softnic/rte_eth_softnic_cli.c:634:73:
>> 	error: the comparison will always evaluate as ‘true’ for the
>> 	address of ‘tc_valid’ will never be NULL [-Werror=address]
>>    634 | (&params->shared_shaper_id.tc_valid[0]) ? 1 : 0,
>>        |                                         ^
>>
>> Fixing it by removing useless check.
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>

     Fixes: 1af2dc5111ce ("net/softnic: add command for default tmgr hierarchy")
     Fixes: 5eb676d74fc8 ("net/softnic: add config flexibility to TM")
     Cc: stable at dpdk.org
     
     Acked-by: Jasvinder Singh <jasvinder.singh at intel.com>

Applied to dpdk-next-net/main, thanks.