[dpdk-dev] [PATCH] hash: promote APIs to stable

Medvedkin, Vladimir vladimir.medvedkin at intel.com
Thu Oct 14 18:46:29 CEST 2021


Hi Honnappa,

On 14/10/2021 02:19, Honnappa Nagarahalli wrote:
> <snip>
> 
>>
>> On Wed, 13 Oct 2021 16:38:58 -0500
>> Honnappa Nagarahalli <honnappa.nagarahalli at arm.com> wrote:
>>
>>> --- a/lib/hash/rte_hash.h
>>> +++ b/lib/hash/rte_hash.h
>>> @@ -430,7 +430,6 @@ rte_hash_get_key_with_position(const struct
>> rte_hash *h, const int32_t position,
>>>    *   - 0 if freed successfully
>>>    *   - -EINVAL if the parameters are invalid.
>>>    */
>>> -__rte_experimental
>>>   int
>>>   rte_hash_free_key_with_position(const struct rte_hash *h,
>>>   				const int32_t position);
>>
>>
>> Need to remove @warning EXPERIMENTAL in comment.
> Agreed
> 
>>
>>
>> What about all the other experimental functions in here?
>> It looks like all of them should be promoted.
> I just changed the symbol that was reported by the tool.
> rte_thash_*** were added on 4/19/2021. Vladimir, are you ok with promoting them?
> 

I think it is too early to make this API stable.

> Yipeng, if you are fine, I can promote rte_hash_lookup_with_hash_bulk, rte_hash_lookup_with_hash_bulk_data and rte_hash_max_key_id. These are around more than a year.
> 

-- 
Regards,
Vladimir


More information about the dev mailing list